Eriksynn issue216 to update example data generator for new dir structure #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el-type directory structure Fixes #216
|
As part of these changes, I standardized on a csv file name of oil-propane.csv because this is the name of the excel tab where all this data comes from. I think it's best to keep the nomenclature similar to the excel sheet source. Comments welcome. |
debajyotid2
requested changes
Jul 11, 2024
debajyotid2
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for new split test directory structure to the example data generator tool. Also added the excel sheets for cowen, gelfand, harris, and karle test examples. Generated new json and csv example data from these new sheets. With these changes we are now ready to complete the refactoring of the test cases to support both oil and ng examples on the fuel-oil-test-cases branch.