Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD 502: Additions section tax calculator, XML elements and PDF fields #4948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Nov 6, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Adding tax calculations, XML and pdf filler for MD 502 Additions, line 3, 6 and 7

How to test?

  • Create a intake with box14_stpickup values on their w-2 to test line 3
  • check that line 6 is equal to line 3
  • check that line 7 is equal to line 6 plus federal AGI

Screenshots (for visual changes)

Screenshot 2024-11-06 at 4 39 15 PM Screenshot 2024-11-06 at 4 40 36 PM

Copy link

github-actions bot commented Nov 6, 2024

Heroku app: https://gyr-review-app-4948-71165336c8c6.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4948 (optionally add --tail)

@embarnard embarnard marked this pull request as ready for review November 6, 2024 21:41
@embarnard embarnard changed the title MD 502 Additions XML and PDF MD 502: Additions section tax calculator, XML elements and PDF fields Nov 6, 2024
Copy link
Contributor

@tahsinaislam tahsinaislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants