Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure .reveal_button elements are real buttons #4943

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Nov 1, 2024

Didn't catch the few new reveals that also needed updating links to buttons :(

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/TBE-118

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Copy link
Contributor

@embarnard embarnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

github-actions bot commented Nov 1, 2024

Heroku app: https://gyr-review-app-4943-ef3b25002dcf.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4943 (optionally add --tail)

@arinchoi03 arinchoi03 merged commit eca2469 into main Nov 1, 2024
7 checks passed
@arinchoi03 arinchoi03 deleted the fix-reveal-buttons branch November 1, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants