Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new FYST production and demo messaging service SIDs to environment credentials #4940

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new FYST production and demo messaging service SIDs to environment credentials #4940

wants to merge 2 commits into from

Conversation

jenny-heath
Copy link
Contributor

@jenny-heath jenny-heath commented Oct 31, 2024 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes?

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • created new messaging service via Twilio console called 'FYST Production' and added short code to sender pool
  • created new messaging service via Twilio console called 'FYST Demo' and added FYST 10DLC to sender pool
  • re-structured Twilio section of environment credentials to have gyr and fyst sections
    • updated references to the gyr credentials around the code

How to test?

  • Acceptance testing should:
    • test sending SMS on heroku; look to see that the message sending status has updated (hub messages tab)
    • same test on demo once merged
    • same test on prod once deployed
  • Risk Assessment
    • this touches the code related to GYR SMS so if we did it wrong, could break that
    • the only change should be that the credentials are nested differently so the references should now reflect that
    • we should generally keep an eye on GYR texting after this is deployed

@jenny-heath @arinchoi03 @mpidcock
Add new FYST production and demo messaging service SIDs to environmen…
da13ecb 
…t credentials

- re-structure twilio credentials to have gyr and fyst sections

Co-authored-by: Arin Choi <[email protected]>
Co-authored-by: Martha Pidcock <[email protected]>
@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4940-6d5179f07227.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4940 (optionally add --tail)

@jenny-heath @arinchoi03 @mpidcock
give heroku its own messaging service
fa83799 
Co-authored-by: Arin Choi <[email protected]>
Co-authored-by: Martha Pidcock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenny-heath @mpidcock