FYST-555 Add MD W2 info to XML #4937
Conversation
| @@ -232,7 +232,7 @@ | |||
| <EmployerEIN>001245768</EmployerEIN> | |||
| <EmployerNameControlTxt>BTB</EmployerNameControlTxt> | |||
| <EmployerName> | |||
| <BusinessNameLine1Txt>Brendan T. Byrne State Forest</BusinessNameLine1Txt> | |||
| <BusinessNameLine1Txt>Brendan T Byrne State Forest</BusinessNameLine1Txt> | |||
| </EmployerName> | |||
There was a problem hiding this comment.
this was erroring out in the state return. I'm assuming federal xmls will not have errors with (.)s so wanted fix this
There was a problem hiding this comment.
👍 double checked that the BusinessNameLine1Txt type should not include periods.
|
Heroku app: https://gyr-review-app-4937-3f02de10b8f3.herokuapp.com/ |
| if existing_deductions | ||
| existing_deductions.add_next_sibling(stpickup_node) | ||
| else | ||
| state_local_tax_grp_node.add_previous_sibling(stpickup_node) |
There was a problem hiding this comment.
Can we tuple about this -- not familiar with this add_child/add_next_sibling pattern and not sure when it's necessary
[Maybe dust or maybe pebble?] Also, if state_local_tax_grp_node does not exist, what happens? It looks like it can be removed on line 13. Is it just not possible for this to happen?
There was a problem hiding this comment.
followup, it is definitely possible for state_local_tax_grp_node to not exist (or to have been removed) See discussion here on why we should find a different node to add previous sibling to or just add at the end of the w2 if there are no other potential nodes
| @@ -232,7 +232,7 @@ | |||
| <EmployerEIN>001245768</EmployerEIN> | |||
| <EmployerNameControlTxt>BTB</EmployerNameControlTxt> | |||
| <EmployerName> | |||
| <BusinessNameLine1Txt>Brendan T. Byrne State Forest</BusinessNameLine1Txt> | |||
| <BusinessNameLine1Txt>Brendan T Byrne State Forest</BusinessNameLine1Txt> | |||
| </EmployerName> | |||
There was a problem hiding this comment.
👍 double checked that the BusinessNameLine1Txt type should not include periods.
|
|
||
| expect(w2_node.css("OtherDeductionsBenefitsGrp Desc")[0]&.text).to eq "414HSUB" | ||
| expect(w2_node.css("OtherDeductionsBenefitsGrp Amt")[0]&.text).to eq "250" | ||
| end |
There was a problem hiding this comment.
[Dust] since the set up is the same for both it blocks in this context, can we just put them all in the same it block & add comments if necessary?
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-555
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)