Nj 105 tax exempt interest income #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmazanec22
force-pushed
the
nj-105-tax-exempt-interest-income
branch
2 times, most recently
from
4fb6bac
to
086e79e
Compare
|
Heroku app: https://gyr-review-app-4934-e6908ee94336.herokuapp.com/ |
mluedke2
reviewed
Oct 30, 2024
spec/fixtures/state_file/fed_return_jsons/2023/nj/exempt_interest_over_10k.json
Show resolved
Hide resolved
mluedke2
reviewed
Oct 30, 2024
mluedke2
approved these changes
Oct 30, 2024
Add gov bonds exceed 10k xml so profile is selectable Add to calculator, xml, pdf
mmazanec22
force-pushed
the
nj-105-tax-exempt-interest-income
branch
from
086e79e
to
6fa7358
Compare
aloverso
approved these changes
Oct 31, 2024
| @@ -3,11 +3,12 @@ | |||
| RSpec.describe PdfFiller::Nj1040Pdf do | |||
| include PdfSpecHelper | |||
|
|
|||
| let(:submission) { create :efile_submission, tax_return: nil, data_source: create(:state_file_nj_intake) } | |||
| let(:submission) { create :efile_submission, tax_return: nil, data_source: intake } | |||
arinchoi03
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://github.com/newjersey/affordability-pm/issues/105
Is PM acceptance required? (delete one)
What was done?
Add tax exempt interest income. Add df data eligibility check.
Do some tidying: in the pdf tests to remove unnecessary code; move some code around to vaguely follow the order in which it appears on the NJ 1040; add some comments in the pdf builder to make it easier to figure out where to put new code.
How to test?
Use the "exempt interest over 10k" profile to see post-df-import rejection.
Use "Zeus two deps" to see line 16b filled.
Screenshots (for visual changes)
The only visual change should be the value filled on the pdf. The page that a user sees after they are deemed ineligible is just the common ineligibiltiy page.