Fyst 823 income documents ID state tax withheld

[arinchoi03]

Link to pivotal/JIRA issue

• FYST-823

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Exact same calculation as was done in calculate_line_53 method in az_calculator.rb
• Porting those values into the respective XML & PDF

How to test?

• Describe the testing approach taken to verify the changes, including:

  • Unit/integration/manual tests
  • Test data used: Miranda 1099R since that one has W2 & 1099R. Miranda has two W-2s with state tax withheld amount (507, 1502) and two 1099Rs with no state tax withheld
  • I tweaked things in unit tests so that we had 1099G / 1099R state withheld amounts

• Risk Assessment

  • Noticed that miranda_1099R had errors on XML output
  • 1. firstName was missing for filer: synchronize_filers_to_database had not run b/c synchronize_w2s_to_database step that comes before had silently failed due to validation on employer_state_id_num field requiring no dashes. Fixed here
  • 2. 1099R was not an expected field: ID/NC does not expect 1099R (or any other income documents) in XML. Removed here

- Please check that Personas with 1099Rs/1099Gs/W2s for NC/ID output XMLs without errors

Screenshots (for visual changes)

[github-actions]

Heroku app: https://gyr-review-app-4933-5563e432acb5.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4933 (optionally add --tail)

[arinchoi03]

w2 sync was failing for this fixture b/c - was included and w2 employer_ein was failing validation

validates :employer_state_id_num, format: { with: /\A(\d{0,17})\z/, message: ->(_object, _data) { I18n.t('state_file.questions.w2.edit.employer_state_id_error') } }

[arinchoi03]

miranda_1099r fixture has a dash in the EmployerStateIdNum. According to schema i think this is a valid character. However, since we validate this field (employer_state_id_num) on save to the database, we should remove any hyphens/dashes.

added a computer gardening seed if we should fail more loudly at Data transfer if errors raise (on non-prod environments; so that we can tell if a fixture has an issue sync'ing)

[arinchoi03]

noticed while looking at id xml output that we were seeing errors for form1099r

Turns out ID / NC does not want income document xml, so removing them here