Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-909 W2 UI Updates #4932

Merged
merged 6 commits into from
Oct 30, 2024
Merged

FYST-909 W2 UI Updates #4932

merged 6 commits into from
Oct 30, 2024

Conversation

tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Oct 30, 2024

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-909

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Added in box14_stpickup for w2 model
  • added in data for in StateInformationService for box 14 and local income boxes
  • Edited view to put in conditions for box 14 and local income boxes

How to test?

  • Added unit tests for the controller

Screenshots (for visual changes)

  • Before
Screenshot 2024-10-29 at 5 40 49 PM
  • After
Screenshot 2024-10-29 at 5 39 50 PM Screenshot 2024-10-29 at 5 37 35 PM

@tahsinaislam tahsinaislam changed the title Fyst 909 fix w2 UI FYST-909 W2 UI Updates Oct 30, 2024
Copy link

Heroku app: https://gyr-review-app-4932-6d91806bd1a6.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4932 (optionally add --tail)

@tahsinaislam tahsinaislam marked this pull request as ready for review October 30, 2024 17:48
@tahsinaislam tahsinaislam merged commit 29f5aa3 into main Oct 30, 2024
12 of 13 checks passed
@tahsinaislam tahsinaislam deleted the fyst-909-fix-w2-ui branch October 30, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant