FYST-796 Add state id pages to Idaho #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-4931-bec436076a0c.herokuapp.com/ |
the copy looks different from what is shown in the screenshot you included in the description -- does it need to be changed? Should connect with design/product to see if this language needs to be specific for Idaho |
arinchoi03
reviewed
Oct 30, 2024
app/views/state_file/questions/id_spouse_state_id/_id_spouse.html.erb
Outdated
Show resolved
Hide resolved
arinchoi03
reviewed
Oct 30, 2024
spec/controllers/state_file/questions/primary_state_id_controller_spec.rb
Outdated
Show resolved
Hide resolved
tahsinaislam
deleted the
FYST-796-add-state-id-pages-to-idaho-flow-update-xml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-796
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)