FYST-791 ID health insurance premium subtraction #4930
Conversation
…ce-premium-subtraction
arinchoi03
force-pushed
the
FYST-791-id-health-insurance-premium-subtraction
branch
from
78c468c
to
d71020a
Compare
|
Heroku app: https://gyr-review-app-4930-0ec0e31e5a55.herokuapp.com/ |
arinchoi03
force-pushed
the
FYST-791-id-health-insurance-premium-subtraction
branch
2 times, most recently
from
ddbca6e
to
7bbc44f
Compare
arinchoi03
force-pushed
the
FYST-791-id-health-insurance-premium-subtraction
branch
from
7bbc44f
to
8593c52
Compare
| presence: true, | ||
| numericality: { | ||
| allow_blank: true, | ||
| greater_than_or_equal_to: 0, |
There was a problem hiding this comment.
open question whether we should allow 0 value for this amount, but should be ok to review while I wait on answer from product
There was a problem hiding this comment.
ok to allow 0 here!
1- it’s possible that the filer may think that they paid Health Insurance Premiums when they initially respond to the question…..but as they more carefully review all of the supporting text in the reveals describing which Health Insurance payments actually qualify for this subtraction they may realize that the Health Insurance Premium payments that they made don’t actually qualify. So allowing them to enter 0 (and filling the PDF field and updating the state XML field with it) is the behavior that we are looking for here.
https://codeforamerica.atlassian.net/browse/FYST-791?focusedCommentId=12716
There was a problem hiding this comment.
if they answer no for health insurance premium question, should we still be adding 0 for the xml and pdf?
There was a problem hiding this comment.
ooh i'll ask this
| @@ -202,6 +202,10 @@ def filer_count | |||
| filing_status_mfj? ? 2 : 1 | |||
| end | |||
|
|
|||
| def household_count | |||
| filer_count + dependents.size | |||
| end | |||
There was a problem hiding this comment.
mike is implementing this on another PR but don't know who will get to merge it first
| @@ -11,7 +11,6 @@ | |||
| <%= | |||
| f.cfa_radio_set( | |||
| :has_unpaid_sales_use_tax, | |||
| label_text: t('.unpaid_sales_use_tax_label_html'), | |||
| collection: [ | |||
There was a problem hiding this comment.
why was this taken out?
There was a problem hiding this comment.
there is not supposed to be a copy above this Yes/No question -- according to figma. I had included the same text twice (text about sales/use amount) & noticed it was different from the figma, so I removed it
| presence: true, | ||
| numericality: { | ||
| allow_blank: true, | ||
| greater_than_or_equal_to: 0, |
There was a problem hiding this comment.
if they answer no for health insurance premium question, should we still be adding 0 for the xml and pdf?
|
|
||
| # ID Review page | ||
| click_on I18n.t("general.continue") | ||
| expect(page).to have_text "Idaho Health Insurance Premium Subtraction" | ||
| expect(page).to have_text "$1,234.60" | ||
|
|
There was a problem hiding this comment.
hmm wondering if going forward we should all add the review page content
There was a problem hiding this comment.
yes i think we should
arinchoi03
deleted the
FYST-791-id-health-insurance-premium-subtraction
branch
Link to pivotal/JIRA issue
FYST-791
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)