Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xml & pdf output for mailing and permanent address in maryland, using stubbed values until FYST-545 is ready #4923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrotondo
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!
    Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Added XML & PDF output that
    • output the DF address to mailing address fields &
    • output either the DF or the user-entered permanent address to the physical address fields

How to test?

  • Go to the heroku deployment,
  • go through the flow confirming your DF address and confirm that it's in the PDF & XML output
  • go through the flow, entering a different address and confirm that it's in the PDF & XML output
  • Risk Assessment
    • We did need to edit the MD502 PDF due to a bug with field names that have unmatched parentheses. This means that we may have to edit the TY2024 PDF when we get it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant