Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative case for NC sales use tax calculation #4920

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add negative case for NC sales use tax calculation #4920

merged 1 commit into from
Nov 1, 2024

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Oct 28, 2024 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Instead of the NC sales use tax calculation returning 0 if the AGI is negative it should return 1; realized this was probably the case after reviewing NJ sales use tax story, here is the thread from that story below:
Screenshot 2024-10-28 at 5 13 26 PM Screenshot 2024-10-28 at 5 13 33 PM

How to test?

  • If AGI is negative for a NC intake then the sales use tax should be 1

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4920-bd626f9f0555.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4920 (optionally add --tail)

arinchoi03
arinchoi03 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@embarnard embarnard merged commit 9733bdf into main Nov 1, 2024
9 checks passed
@embarnard embarnard deleted the FYST-1039-nc-sales-use-tax-calculation-should-return-0-if-agi-is-negative branch November 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

Assignees
No one assigned
Labels
in-acceptance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@embarnard @arinchoi03