Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative case for NC sales use tax calculation #4919

Closed
wants to merge 1 commit into from

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Oct 28, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Instead of the NC sales use tax calculation returning 0 if the AGI is negative it should return 1; realized this was probably the case after reviewing NJ sales use tax story, here is the thread from that story below:
Screenshot 2024-10-28 at 5 13 26 PM Screenshot 2024-10-28 at 5 13 33 PM

How to test?

  • If AGI is negative for a NC intake then the sales use tax should be 1

Copy link

Heroku app: https://gyr-review-app-4919-7c71034591ab.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4919 (optionally add --tail)

@embarnard embarnard closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant