Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJ 108 - line 58 basic EITC calculation from federal #4915

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

aloverso
Copy link
Contributor

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/108

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Basic case for EITC - calculate as 40% of federal when it exists

How to test?

  • minimal for no federal EITC
  • two_w2s has federal amount $1490

Screenshots (for visual changes)

image

image

Copy link

Heroku app: https://gyr-review-app-4915-5f6d5f96a145.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4915 (optionally add --tail)

@aloverso aloverso marked this pull request as ready for review October 28, 2024 17:31
Copy link
Contributor

@mmazanec22 mmazanec22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward!

Copy link
Contributor

@mrotondo mrotondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, sorry for the delay

app/lib/efile/nj/nj1040_calculator.rb Outdated Show resolved Hide resolved
app/lib/efile/nj/nj1040_calculator.rb Outdated Show resolved Hide resolved
@aloverso aloverso merged commit 16c9a13 into main Oct 30, 2024
7 checks passed
@aloverso aloverso deleted the nj-108-basic-eitc branch October 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants