Fyst 789/add child credit xml pdf #4903
Conversation
|
Heroku app: https://gyr-review-app-4903-11272b817bee.herokuapp.com/ |
| xml: nil, # TODO 39RForm xml to be added in future story | ||
| pdf: PdfFiller::Id39rPdf, | ||
| xml: SubmissionBuilder::Ty2024::States::Id::Documents::Id39r, | ||
| pdf: PdfFiller::Id39rPdf, | ||
| include: @submission.data_source.dependents.count > 4 | ||
| }, |
There was a problem hiding this comment.
i would make this include: true because the id39R should be included not just for listing dependents
There was a problem hiding this comment.
This was inherited from another ticket that also was touching 39rForm. I think it would break that.
|
Heroku app: https://gyr-review-app-4903-48512e1aeab6.herokuapp.com/ |
| @@ -16,18 +16,19 @@ def initialize(submission) | |||
|
|
|||
| def hash_for_pdf | |||
| answers = { | |||
| "BL6" => @xml_document.at('Form39R ChildCareCreditAmt')&.text, | |||
There was a problem hiding this comment.
@powersurge360 how come you included the Form39R here, as opposed to the other selectors IncomeUSObligations and HealthInsurancePaid fields?
There was a problem hiding this comment.
I don't think you strictly need it if there is only one particular ChildCareCreditAmt. I mostly did it for clarity and specificity I suppose.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
What was done?
How to test?
Screenshots (for visual changes)
Before
XML
PDF
After
XML
PDF
