fix PR

codeforamerica · Oct 30, 2024 · 2d8e1e0 · 2d8e1e0
1 parent e05fa1a
commit 2d8e1e0
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 15 deletions.
diff --git a/app/lib/navigation/state_file_id_question_navigation.rb b/app/lib/navigation/state_file_id_question_navigation.rb
@@ -30,9 +30,9 @@ class StateFileIdQuestionNavigation < Navigation::StateFileBaseQuestionNavigatio
         Navigation::NavigationStep.new(StateFile::Questions::DataTransferOffboardingController, false),
         Navigation::NavigationStep.new(StateFile::Questions::IncomeReviewController),
         Navigation::NavigationStep.new(StateFile::Questions::UnemploymentController),
+        Navigation::NavigationStep.new(StateFile::Questions::IdSalesUseTaxController),
         Navigation::NavigationStep.new(StateFile::Questions::PrimaryStateIdController),
         Navigation::NavigationStep.new(StateFile::Questions::SpouseStateIdController),
-        Navigation::NavigationStep.new(StateFile::Questions::IdSalesUseTaxController),
         Navigation::NavigationStep.new(StateFile::Questions::IdReviewController),
         Navigation::NavigationStep.new(StateFile::Questions::EsignDeclarationController), # creates EfileSubmission and transitions to preparing
       ]),

diff --git a/app/views/state_file/questions/id_spouse_state_id/_id_spouse.html.erb b/app/views/state_file/questions/id_spouse_state_id/_id_spouse.html.erb
@@ -20,7 +20,7 @@
 
 <% content_for :card do %>
   <h1 class="h2"><%= title %></h1>
-  <%= render 'state_file/questions/ny_primary_state_id/state_id', options: {
+  <%= render 'state_file/questions/primary_state_id/state_id', options: {
     info_link: "https://itd.idaho.gov/news/idahos-new-license-and-id-card-are-here/"
   } %>
 <% end %>
diff --git a/app/views/state_file/questions/primary_state_id/_state_id.html.erb b/app/views/state_file/questions/primary_state_id/_state_id.html.erb
@@ -1,3 +1,4 @@
+<p> <%= t("state_file.questions.primary_state_id.edit.subtitle") %> </p>
 <%= form_with model: @form, url: { action: :update }, local: true, method: "put", builder: VitaMinFormBuilder do |f| %>
   <% if params[:return_to_review].present? %>
     <%= hidden_field_tag "return_to_review", params[:return_to_review] %>

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -2921,8 +2921,9 @@ en:
           title: Enter your phone number
       primary_state_id:
         edit:
-          ny_subtitle: This information is required for all NY residents with a state-issued ID.
-          title: Please share some details from your state-issued ID
+          ny_subtitle: We need some details from .
+          subtitle: Provide your driver’s license or identity card number when you e-File to help your refund process faster.
+          title: We need some details from your state-issued ID, if you have one
         state_id:
           id_details:
             expiration: Expiration Date
@@ -3002,7 +3003,7 @@ en:
           your_tax_owed: Your taxes owed
       spouse_state_id:
         edit:
-          title_html: Please provide information for <strong>your spouse’s</strong> state issued ID
+          title_html: We need some details from <strong>your spouse’s</strong> state-issued ID, if they have one
       submission_confirmation:
         edit:
           download_state_return_pdf: Download your state return

diff --git a/config/locales/es.yml b/config/locales/es.yml
@@ -2910,7 +2910,8 @@ es:
       primary_state_id:
         edit:
           ny_subtitle: Esta información es necesaria para todos los residentes de Nueva York con una identificación emitida por el estado.
-          title: Comparte algunos detalles de tu identificación emitida por el estado
+          subtitle: Proporcione su número de licencia de conducir o tarjeta de identidad cuando presente su declaración electrónica para ayudar a procesar su reembolso más rápido.
+          title: Necesitamos algunos detalles de su documento de identidad oficial, si tiene uno
         state_id:
           id_details:
             expiration: Fecha de Vencimiento
@@ -2990,7 +2991,7 @@ es:
           your_tax_owed: Tus impuestos adeudados
       spouse_state_id:
         edit:
-          title_html: Proporciona la información para la identificación emitida por el estado de <strong>tu cónyuge</strong>
+          title_html: Necesitamos algunos detalles del documento de identidad oficial de <strong>su cónyuge</strong>, si tiene uno
       submission_confirmation:
         edit:
           download_state_return_pdf: Descarga tu declaración estatal

diff --git a/spec/features/state_file/complete_intake_spec.rb b/spec/features/state_file/complete_intake_spec.rb
@@ -492,25 +492,25 @@
       # 1099G Review
       click_on I18n.t("general.continue")
 
+      expect(page).to have_text I18n.t('state_file.questions.id_sales_use_tax.edit.title', year: MultiTenantService.statefile.current_tax_year)
+      choose I18n.t("general.affirmative")
+      fill_in 'state_file_id_sales_use_tax_form_total_purchase_amount', with: "290"
+
+      click_on I18n.t("general.continue")
+
       expect(page).to have_text I18n.t('state_file.questions.primary_state_id.edit.title')
+      click_on I18n.t("state_file.questions.id_primary_state_id.id_primary.why_ask_this")
+      expect(page).to have_text I18n.t('state_file.questions.id_primary_state_id.id_primary.protect_identity')
       choose I18n.t('state_file.questions.primary_state_id.state_id.id_type_question.dmv')
       fill_in I18n.t('state_file.questions.primary_state_id.state_id.id_details.number'), with: "012345678"
       select_cfa_date "state_file_primary_state_id_form_issue_date", 4.years.ago.beginning_of_year
       select_cfa_date "state_file_primary_state_id_form_expiration_date", 4.years.from_now.beginning_of_year
       select("Idaho", from: I18n.t('state_file.questions.primary_state_id.state_id.id_details.issue_state'))
       click_on I18n.t("general.continue")
 
-      expect(page).to have_text I18n.t('state_file.questions.id_sales_use_tax.edit.title', year: MultiTenantService.statefile.current_tax_year)
-      choose I18n.t("general.affirmative")
-      fill_in 'state_file_id_sales_use_tax_form_total_purchase_amount', with: "290"
-
       # ID Review page
       click_on I18n.t("general.continue")
 
-      # TODO: uncomment when the name dob page is added; test fails without a name
-      # expect(page).to have_text(I18n.t('state_file.questions.unemployment.index.1099_label', name: StateFileIdIntake.last.primary.full_name))
-      click_on I18n.t("general.continue")
-
       expect(page).to have_text I18n.t("state_file.questions.esign_declaration.edit.title", state_name: "Idaho")
       check I18n.t("state_file.questions.esign_declaration.edit.primary_esign")
       click_on I18n.t("state_file.questions.esign_declaration.edit.submit")