Fix expense calculator bug #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
approved these changes
May 24, 2024
Also changes an equal to equalsIgnoreCase. If a user enters a money on hand amount, but then goes back and decides they have less than 100 on hand, we will clear out the amount they entered so it doesn't affect calculations.
bseeger
reviewed
May 24, 2024
| new BigDecimal(inputData.getOrDefault(inputFieldName, "0").toString()) | ||
| .setScale(2, RoundingMode.HALF_UP)); | ||
|
|
||
| if (!val.equalsIgnoreCase("None")) { |
There was a problem hiding this comment.
@spokenbird I changed this to "equalsIgnoreCase()" so that we still do the right thing if someone accidentally changes this to "NONE" or "none".
bseeger
reviewed
May 24, 2024
| @@ -82,6 +82,7 @@ flow: | |||
| nextScreens: | |||
| - name: expeditedSnapMoneyOnHand | |||
| expeditedSnapMoneyOnHand: | |||
| onPostAction: MaybeClearMoneyOnHandAmount | |||
| beforeSaveAction: CheckExpeditedSnapEligibility | |||
There was a problem hiding this comment.
I added a new action to clear out the money amount in the event that they said they had money, but then went back and changed their mind on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.