Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use zstd instead of gzip for compression #405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

  • use zstandard compression in write_file
  • if the content encoding is set to zstd, manually decompress the downloaded bytes using ztd
  • remove logic from renaming content_type in read_file
  • setup VCR in test_gcp to match on the body

- use zstandard compression in write_file
- if the content encoding is set to zstd, manually
  decompress the downloaded bytes using ztd
- remove logic from renaming content_type in
  read_file
- setup VCR in test_gcp to match on the body
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (f408749) to head (9d5325c).
Report is 6 commits behind head on main.

Current head 9d5325c differs from pull request most recent head 28c85d4

Please upload reports for the commit 28c85d4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   90.33%   89.84%   -0.49%     
==========================================
  Files         383      324      -59     
  Lines       11713     9564    -2149     
  Branches     2052     1711     -341     
==========================================
- Hits        10581     8593    -1988     
+ Misses       1039      907     -132     
+ Partials       93       64      -29     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant