Make dailytestrollup branch nullable #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -404,7 +404,7 @@ class PartitioningMeta: | |||
| ) | |||
| date = models.DateField() | |||
| repoid = models.IntegerField() | |||
| branch = models.TextField() | |||
| branch = models.TextField(null=True) | |||
There was a problem hiding this comment.
@joseph-sentry I'll summon thee to see if it'd affect your work
There was a problem hiding this comment.
ah this is fine i think, it's probably crashing the test results processor at the moment, I find it weird that we have commits with no branch but i guess that's a separate issue
I'm not sure if it's better to just skip inserting into the rollups table if the branch is null though
michelletran-codecov
force-pushed
the
fix_integrity_errors
branch
from
08268e8
to
a711b12
Compare
We've been seeing a bunch of errors related to this field not being nullable. This is because it's taking the branch from the commit, which _can_ be nullable. See: [error](https://codecov.sentry.io/share/issue/478a3e60158547b69afa0b9959822237/)
michelletran-codecov
force-pushed
the
fix_integrity_errors
branch
from
a711b12
to
265b8e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly, I'm not sure if this is the right solution, but we've been seeing a bunch of errors related to this field not being nullable (see error in Sentry). This is because it's taking the branch from the commit, which can be nullable.
This would also fix a bunch of errors seen in codecov/worker#729
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.