2027 add exceptions when token is rate limited #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit-fns-to-gh-api-calls
…imit-fns-to-gh-api-calls
…imit-fns-to-gh-api-calls
…tions-when-token-is-rate-limited
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2164-add-rate-limit-fns-to-gh-api-calls #310 +/- ##
========================================================================
Coverage 89.27% 89.27%
========================================================================
Files 324 324
Lines 9929 9929
Branches 1775 1775
========================================================================
Hits 8864 8864
Misses 1001 1001
Partials 64 64 ☔ View full report in Codecov by Sentry. |
adrian-codecov
changed the base branch from
main
to
2164-add-rate-limit-fns-to-gh-api-calls
…main' of github.com:codecov/shared into 2027-add-exceptions-when-token-is-rate-limited
…imit-fns-to-gh-api-calls
…codecov/shared into 2027-add-exceptions-when-token-is-rate-limited
Base automatically changed from
2164-add-rate-limit-fns-to-gh-api-calls
to
main
August 26, 2024 16:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to this pr #303 and should only be merged after 303 is merged. This adds a layer of validation to see if a token is rate limited upon the auth_information is created. This mostly adds the EntityRateLimitedException as well as a test for it.
The files that have additional changes/only ones different from 303 are
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.