fix: PullCoverage a passing null instead of boolean (#3679)

codecov · Jan 24, 2025 · 9a77add · 9a77add
1 parent b7ce614
commit 9a77add
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/...stPage/PullCoverage/PullCoverage.test.jsx → ...stPage/PullCoverage/PullCoverage.test.tsx b/...stPage/PullCoverage/PullCoverage.test.jsx → ...stPage/PullCoverage/PullCoverage.test.tsx
@@ -44,7 +44,7 @@ vi.mock('./routes/ComponentsTab', () => ({
   default: () => <div>ComponentsTab</div>,
 }))
 
-const mockPullData = (resultType) => {
+const mockPullData = (resultType: string) => {
   if (resultType !== ComparisonReturnType.SUCCESSFUL_COMPARISON) {
     return {
       owner: {
@@ -181,7 +181,9 @@ const queryClientV5 = new QueryClientV5({
 })
 
 const wrapper =
-  (initialEntries = '/gh/codecov/test-repo/pull/1') =>
+  (
+    initialEntries = '/gh/codecov/test-repo/pull/1'
+  ): React.FC<React.PropsWithChildren> =>
   ({ children }) => (
     <QueryClientProviderV5 client={queryClientV5}>
       <QueryClientProvider client={queryClient}>
@@ -213,6 +215,14 @@ afterAll(() => {
   server.close()
 })
 
+interface SetupArgs {
+  resultType?: string
+  isTeamPlan?: boolean
+  bundleAnalysisEnabled?: boolean
+  coverageEnabled?: boolean
+  isGithubRateLimited?: boolean
+}
+
 describe('PullRequestPageContent', () => {
   function setup(
     {
@@ -221,7 +231,7 @@ describe('PullRequestPageContent', () => {
       bundleAnalysisEnabled = false,
       coverageEnabled = false,
       isGithubRateLimited = false,
-    } = {
+    }: SetupArgs = {
       resultType: ComparisonReturnType.SUCCESSFUL_COMPARISON,
       isTeamPlan: false,
       bundleAnalysisEnabled: false,

diff --git a/...RequestPage/PullCoverage/PullCoverage.jsx → ...RequestPage/PullCoverage/PullCoverage.tsx b/...RequestPage/PullCoverage/PullCoverage.jsx → ...RequestPage/PullCoverage/PullCoverage.tsx
@@ -34,8 +34,15 @@ const Loader = () => (
   </div>
 )
 
+interface URLParams {
+  owner: string
+  repo: string
+  pullId: string
+  provider: string
+}
+
 function PullCoverageContent() {
-  const { owner, repo, pullId, provider } = useParams()
+  const { owner, repo, pullId, provider } = useParams<URLParams>()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
   const { data: isTeamPlan } = useIsTeamPlan({ provider, owner })
 
@@ -123,7 +130,7 @@ function PullCoverageContent() {
 }
 
 function PullCoverage() {
-  const { owner, repo, pullId, provider } = useParams()
+  const { owner, repo, pullId, provider } = useParams<URLParams>()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
   const { data: isTeamPlan } = useIsTeamPlan({ provider, owner })
   const { data: rateLimit } = useRepoRateLimitStatus({ provider, owner, repo })
@@ -134,7 +141,7 @@ function PullCoverage() {
       owner,
       repo,
       pullId,
-      isTeamPlan: isTeamPlan && overview?.private,
+      isTeamPlan: (isTeamPlan && overview?.private) ?? false,
     })
   )
 

diff --git a/...ges/PullRequestPage/PullCoverage/index.js → ...ges/PullRequestPage/PullCoverage/index.ts b/...ges/PullRequestPage/PullCoverage/index.js → ...ges/PullRequestPage/PullCoverage/index.ts