-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove token enforcement for true tokenless endpoints #533
base: main
Are you sure you want to change the base?
Conversation
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Just a few comments about the type annotation.
Agreed, this looks good to me. I'd like to know, however, that this change has been tested on
|
# Conflicts: # codecov_cli/services/upload/__init__.py
Went through the upload endpoints on API:
endpoints where we want to allow tokenless: I've made sure the method uses
get_token_header()
which allowsNone
for thetoken
, which will allow tokenless requests through to the api.endpoints where we don't want to allow tokenless: I've made sure they use
get_token_header_or_fail()
which does not allowNone
, so the request will be kicked out before it gets to api. This is not required for the tokenless logic to work, but is nice to have since it prevents junk requests from clogging api.