fix: make inf percent change result null (#990)

codecov · Nov 19, 2024 · 4a2bb9b · 4a2bb9b
1 parent ace92d6
commit 4a2bb9b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/graphql_api/types/flake_aggregates/flake_aggregates.py b/graphql_api/types/flake_aggregates/flake_aggregates.py
@@ -42,7 +42,11 @@ def flake_aggregates_with_percentage(
     merged_results: pl.DataFrame = pl.concat([past_aggregates, curr_aggregates])
 
     merged_results = merged_results.with_columns(
-        pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")
+        pl.all()
+        .pct_change()
+        .replace([float("inf"), float("-inf")], None)
+        .fill_nan(0)
+        .name.suffix("_percent_change")
     )
     aggregates = merged_results.row(1, named=True)
 

diff --git a/graphql_api/types/test_results_aggregates/test_results_aggregates.py b/graphql_api/types/test_results_aggregates/test_results_aggregates.py
@@ -71,7 +71,11 @@ def test_results_aggregates_with_percentage(
     # with_columns upserts the new columns, so if the name already exists it get overwritten
     # otherwise it's just added
     merged_results = merged_results.with_columns(
-        pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")
+        pl.all()
+        .pct_change()
+        .replace([float("inf"), float("-inf")], None)
+        .fill_nan(0)
+        .name.suffix("_percent_change")
     )
     aggregates = merged_results.row(1, named=True)