Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Heroku stack to heroku-20 and bump Ruby version to 2.5.9 #1877

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

matyikriszta
Copy link
Contributor

Description

We need to update the stack we are using on Heroku. We are currently on heroku-18 which reached EOL in April. This means we can no longer deploy to Heroku. This PR updates the stack to heroku-20 and the Ruby version to 2.5.9 which is the earliest supported Ruby on the heroku-20 stack.

Status

Ready for Review

Related Github issue

#1876

@matyikriszta matyikriszta force-pushed the heroku-stack-and-ruby-bump branch from 25140bd to ffce6c5 Compare July 19, 2023 23:15
@gnclmorais
Copy link
Contributor

Sweet work! I guess this PR needs to be reviewed and merged before https://github.com/codebar/planner/pull/1874…

@matyikriszta matyikriszta force-pushed the heroku-stack-and-ruby-bump branch from ffce6c5 to edbaf60 Compare July 20, 2023 18:59
Copy link

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with Kriszta on this at the time.

Old-ruby on M1 macs requires that funky flag to cause a successful install, but that shall go away once we get onto ruby 3.1/3.2.

@matyikriszta matyikriszta merged commit 73f17db into master Jul 20, 2023
@matyikriszta matyikriszta deleted the heroku-stack-and-ruby-bump branch July 20, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants