-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinaryReader #23
base: master
Are you sure you want to change the base?
BinaryReader #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Thanks for the PR! I hope to see more problems in the future :)
Also, try your best to pass the style checks (if they're just getting you on annoying stuff just let me know and I can override them).
for(int j = 0; j < arr[0].length; j++) | ||
{ | ||
//Check if current element is set to true | ||
if(arr[i][j] == true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually change this line to
if(arr[i][j] == true) | |
if(arr[i][j]) | |
Create a program called BinaryReader in which a 4 x 4 | ||
array of booleans is created. Have the computer loop | ||
through the array, printing a 0 if the current element is | ||
set to false and a 1 if it set to true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having them create an array themselves, you might want to consider having this be a method instead (the 4x4 array is the parameter and the method either prints or returns the string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New practice problem for Java Intermediate Lesson 10.2