Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json forgot comma #2369

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Update manifest.json forgot comma #2369

merged 4 commits into from
Jun 12, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jun 11, 2024

I was going to also fix FF compatibility, but:
with "service_worker": changed to "scripts": https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox/78088358#78088358 needs both

"background": {
    "service_worker": "background.js",
    "scripts": ["background.js"]
},

for full cross compatibility with Firefox under V3 manifest
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/background#browser_support
Issue: warnins in both browsers :/. Firefox one:

Warning details

Reading manifest: Warning processing background.service_worker: An unexpected property was found in the WebExtension manifest.

Chrome one:
'background.scripts' requires manifest version of 2 or lower.

@raszpl raszpl marked this pull request as ready for review June 11, 2024 22:22
@raszpl raszpl changed the title Update manifest.json forgot comma Update manifest.json forgot comma, fix FF compatibility Jun 12, 2024
@raszpl raszpl changed the title Update manifest.json forgot comma, fix FF compatibility Update manifest.json forgot comma Jun 12, 2024
@ImprovedTube ImprovedTube merged commit fa7833b into code-charity:master Jun 12, 2024
1 check passed
@ImprovedTube
Copy link
Member

just to confuse: Firefox can stay manifest2 it seems.

@raszpl raszpl deleted the patch-5 branch June 12, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants