Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved: toggle cards shortcut working #1846

Closed
wants to merge 1 commit into from

Conversation

pg2511
Copy link
Member

@pg2511 pg2511 commented Nov 21, 2023

Resolving Issue: #1845
Hello, @ImprovedTube , this PR is created to resolve the issue of toggling cards coming up at the end of youtube video.

Here is a detailed video as a result of changes done:
Toggle Cards.webm

How it works:

  • Go to Shortcuts
  • Create a shortcut for Toggle cards
  • Now play any youtube video
  • When toggling cards show, press shortcut it will hide, press again they will show (Toggling functionality perfectly working now)

Have a look, and please merge this PR, feel free to share suggestions if any.

@pg2511
Copy link
Member Author

pg2511 commented Nov 22, 2023

After further consideration, I realize there were misunderstandings in my initial approach. I'm closing this PR to make necessary adjustments.

@pg2511 pg2511 closed this Nov 22, 2023
@pg2511 pg2511 deleted the praffulgupta/toggleCards branch November 22, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant