utils: Add unit tests for util.rs #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests to check correct behavior of auxiliary functions in util.rs. Signed-off-by: Carlos Bilbao <[email protected]>
00xc
suggested changes
Nov 9, 2023
Comment on lines
+82
to
+83
| let start = VirtAddr::new(&mut data[0] as *mut u8 as usize); | ||
| let end = start + 10; |
There was a problem hiding this comment.
Suggested change
| let start = VirtAddr::new(&mut data[0] as *mut u8 as usize); | |
| let end = start + 10; | |
| let start = VirtAddr::from(data.as_mut_ptr()); | |
| let end = start + core::mem::size_of_val(&data); |
There was a problem hiding this comment.
@Zildj1an Please fix this with a follow-on PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to check correct behavior of auxiliary functions in util.rs.