Fix nightly clippy warnings #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warning that will appear on a future (e.g. nightly)
version of clippy:
warning: use of a fallible conversion when an infallible one could be used
--> src/svsm.rs:332:46
|
332 | launch_info.kernel_region_phys_start.try_into().unwrap(),
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
warning: use of a fallible conversion when an infallible one could be used
--> src/svsm.rs:333:44
|
333 | launch_info.kernel_region_phys_end.try_into().unwrap(),
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
Signed-off-by: Carlos López <[email protected]>
Fix several warnings like the following that will appear on a future
(e.g. nightly) version of clippy:
warning: use of a fallible conversion when an infallible one could be used
--> src/elf/mod.rs:621:25
|
621 | let shdr_size = usize::try_from(elf_hdr.e_shentsize).unwrap();
| ^^^^^^^^^^^^^^^ help: use: `From::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
Signed-off-by: Carlos López <[email protected]>
Fix the followiing warnings like that will appear on a future
(e.g. nightly) version of clippy:
warning: use of a fallible conversion when an infallible one could be used
--> src/cpu/percpu.rs:426:48
|
426 | vmsa_ref.rsp = self.get_top_of_stack().try_into().unwrap();
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
warning: use of a fallible conversion when an infallible one could be used
--> src/cpu/percpu.rs:427:55
|
427 | vmsa_ref.cr3 = self.get_pgtable().cr3_value().try_into().unwrap();
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
Signed-off-by: Carlos López <[email protected]>
Rename the Page enum to PageInfo, and remove the "Page" suffix of
variants' names that have it to improve readability. This also fixes
the following warnings that will appear on a future (e.g. nightly)
version of clippy:
warning: variant name ends with the enum's name
--> src/mm/alloc.rs:197:5
|
197 | SlabPage(SlabPageInfo),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
warning: variant name ends with the enum's name
--> src/mm/alloc.rs:198:5
|
198 | CompoundPage(CompoundInfo),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name ends with the enum's name
--> src/mm/alloc.rs:199:5
|
199 | FilePage(FileInfo),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
Signed-off-by: Carlos López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings that appear on the nightly version of clippy. These simply improve code clarity, there is no functional change.