Add support for running tests inside stage2 #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the failing test case. This also breaks the test-in-svsm target. |
These tests can't be run inside the svsm kernel and they can't be run inside stage2 either. Signed-off-by: Adam Dunlap <[email protected]>
In the same way that support was added for running tests inside the svsm kernel, add tests that run inside stage2. This is useful for stage2-specific componenets such as the stage 2 #VC handler. Signed-off-by: Adam Dunlap <[email protected]>
AdamCDunlap
force-pushed
the
stage2-tests
branch
from
0c5d848 to
d7fde53
Compare
|
Thanks for taking a look!
I updated the github action to build the stage2.bin target since it's required to do that before building stage1. I think it'd be better if this was not necessary, but this is how it was done when the test-kernel target was added and I'm not sure how to do it better.
Fixed in the same way. I missed that because it only breaks if you make clean first. Also rebased and fixed merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way that support was added for running tests inside the svsm kernel, add tests that run inside stage2. This is useful for stage2-specific componenets such as the stage 2 #VC handler.