cockroachkvs: pull in MVCC block-property collector, filter #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Could we move them to a new file? I was considering splitting the cockroachkvs.go file into the comparer and key schema (like they were in cockroach). |
Copy the MVCC time interval block property collector and filter implementations from CockroachDB's pkg/storage package. These will be used within the metamorphic test when using the cockroachkvs key format.
jbowens
force-pushed
the
cockroachkvs-bpf
branch
from
6731d31 to
20f28e1
Compare
jbowens
commented
Jan 23, 2025
There was a problem hiding this comment.
Sure, done.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @aadityasondhi and @RaduBerinde)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the MVCC time interval block property collector and filter implementations from CockroachDB's pkg/storage package. These will be used within the metamorphic test when using the cockroachkvs key format.