sstable/block: fix Buffer growth bug #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jbowens and @sumeerbhola)
sstable/block/compression.go line 453 at r1 (raw file):
// buffer. func (p *bufferSyncPool) Put(bh *BufHandle) { if bh.pool == nil {
[nit] should we check that bh.pool == p.pool?
Fix a bug whereby Buffer.AppendValue would fail to sufficiently grow the capacity of its backing byte slice. Previously, AppendValue used cap(buf) when calculating the argument to slices.Grow, but slices.Grow expects its argument to be in terms of the slice's current length, not capacity. Add a focused randomized test that catches the bug. Also, add invariant assertions around a BufHandle's existence in or out of a pool. Fix cockroachdb#4247.
jbowens
force-pushed
the
blockbuffer-bug
branch
from
4a87f72 to
9ec4be6
Compare
jbowens
commented
Jan 10, 2025
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @sumeerbhola)
sstable/block/compression.go line 453 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] should we check that
bh.pool == p.pool?
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug whereby Buffer.AppendValue would fail to sufficiently grow the capacity of its backing byte slice. Previously, AppendValue used cap(buf) when calculating the argument to slices.Grow, but slices.Grow expects its argument to be in terms of the slice's current length, not capacity.
Add a focused randomized test that catches the bug. Also, add invariant assertions around a BufHandle's existence in or out of a pool.
Fix #4247.