Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cockroachdb-ca-cert duration and renewal interval #398

Conversation

mekaan
Copy link
Contributor

@mekaan mekaan commented Jun 19, 2024

Addresses the issue #397

@rail rail requested a review from prafull01 June 19, 2024 14:49
@mekaan mekaan marked this pull request as ready for review June 19, 2024 14:51
@mekaan
Copy link
Contributor Author

mekaan commented Jul 2, 2024

Att: @prafull01 (cc: @rail )
PR is failing in the Linting stage with is just a git diff, when I try it, it works without any issue but I am not sure why it is failing. Can you help to resolve it?

@rail
Copy link
Member

rail commented Jul 2, 2024

You can run go run build/build.go generate to update the generated files and the lint check should pass.

@mekaan
Copy link
Contributor Author

mekaan commented Jul 4, 2024

Can I get an approval for the checks to run? @rail @prafull01

@mekaan
Copy link
Contributor Author

mekaan commented Jul 16, 2024

Are we going to be able to merge this PR, It looks ready. @rail @prafull01

@rail
Copy link
Member

rail commented Jul 16, 2024

I'll let @prafull01 to chime in.

@mekaan
Copy link
Contributor Author

mekaan commented Jul 23, 2024

Do we have any update about this @prafull01?

@mekaan
Copy link
Contributor Author

mekaan commented Aug 7, 2024

Can we get someone else on this @rail? @prafull01 looks inactive for the last 3 months🤔

Copy link

@udnay udnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rail rail merged commit 7d9b095 into cockroachdb:master Aug 7, 2024
9 checks passed
@rail
Copy link
Member

rail commented Aug 7, 2024

@mekaan thank you for your contribution and sorry for the delay!

@mekaan
Copy link
Contributor Author

mekaan commented Aug 14, 2024

Thanks a lot 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants