Add support for custom annotations to the Init Job #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pseudomuto and @rail, could you maybe take a look at this PR, please? 😬 |
pseudomuto
approved these changes
Jun 9, 2022
cockroachdb/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ | |||
| apiVersion: v1 | |||
| name: cockroachdb | |||
| home: https://www.cockroachlabs.com | |||
| version: 8.0.1 | |||
| version: 8.0.2 | |||
There was a problem hiding this comment.
Since we're adding a new feature I think we should make this new version 8.1.0.
rail
requested changes
Jun 9, 2022
In some cases, there is a need for adding custom annotations to the Init job. For example, when using ArgoCD, we need to instruct ArgoCD to start the job still during the Sync phase and not as a PostSync hook. Otherwise, the job never starts. And this is done by adding the following annotation to the job. ``` argocd.argoproj.io/hook: Sync ``` This is to continue the work started in cockroachdb#246 to address cockroachdb#149
Bumping the chart version for a new release.
diogokiss
force-pushed
the
init-job-annotations
branch
from
57be672 to
87c8039
Compare
|
@rail and @pseudomuto, I've addressed and force-pushed the requested changes. 🤝 |
|
On another note, I saw this. What is the recommended way of installing CockroachDB in a K8s cluster? Is it via Helm or Operator? Just for clarification. Also, I have another issue opened that seems not to affect the Operator. So, if I'm supposed to use the Operator, I'll not even bother to wait for it to be resolved. |
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, there is a need for adding custom annotations to the Init job.
For example, when using ArgoCD, we need to instruct ArgoCD to start the job
still during the Sync phase and not as a PostSync hook. Otherwise, the job never
starts. And this is done by adding the following annotation to the job.
This is to continue the work started in #246 and #206
to address #149