Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFX 24 Term 3: Meshery #1290

Merged
merged 3 commits into from
Jul 31, 2024
Merged

LFX 24 Term 3: Meshery #1290

merged 3 commits into from
Jul 31, 2024

Conversation

Yashsharma1911
Copy link
Contributor

@Yashsharma1911 Yashsharma1911 commented Jul 30, 2024 •
edited
Loading

@Yashsharma1911
LFX 24 Term 3: Meshery
e5a30c0 
Signed-off-by: Yash sharma <[email protected]>
nate-double-u
nate-double-u reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Yashsharma1911,

@leecalcote, @aabidsofi19, @nebula-aac, could you each 👍 or approve this PR to confirm your participation?

leecalcote
leecalcote approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Yashsharma1911
Copy link
Contributor Author

Conflict resolved

@leecalcote
Copy link
Member

Typical. Always starting trouble... having one conflict or another, @Yashsharma1911. 🤪

nate-double-u
nate-double-u approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I see everyone has 👍 or approved now.

@nate-double-u nate-double-u merged commit c2ebb11 into cncf:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@leecalcote leecalcote leecalcote approved these changes

@aabidsofi19 aabidsofi19 aabidsofi19 approved these changes

Assignees
No one assigned
Labels
2024 lfx mentorship Term 3: Sept-Nov
Projects
TAG Contributor Strategy Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yashsharma1911 @leecalcote @nate-double-u @aabidsofi19