Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFX Summer 2024: Meshery #1245

Merged
merged 5 commits into from
May 15, 2024
Merged

LFX Summer 2024: Meshery #1245

merged 5 commits into from
May 15, 2024

Conversation

Yashsharma1911
Copy link
Contributor

No description provided.

@Yashsharma1911
LFX Summer 2024: Meshery
41d503f 
Signed-off-by: Yash sharma <[email protected]>
nate-double-u
nate-double-u reviewed May 13, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yashsharma1911, thanks for this!

@leecalcote, @aabidsofi19, and @MUzairS15 could you 👍 or approve this PR to confirm your participation?

@Yashsharma1911, Could you also resolve the merge conflicts?

@Yashsharma1911
Copy link
Contributor Author

Hi @Yashsharma1911, thanks for this!

@leecalcote, @aabidsofi19, and @MUzairS15 could you 👍 or approve this PR to confirm your participation?

@Yashsharma1911, Could you also resolve th emerge conflicts?

Thankyou @nate-double-u conflicts resolved now

leecalcote
leecalcote approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nate-double-u
nate-double-u approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

nate-double-u
nate-double-u requested changes May 14, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target programs/lfx-mentorship/2024/02-Jun-Aug/project_ideas.md, part of our process is moving from project ideas to the README as the LFX approves the project.

@Yashsharma1911
Moved to project ideas
0e936fd 
Signed-off-by: Yash Sharma <[email protected]>
nate-double-u
nate-double-u approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

/approve

@nate-double-u nate-double-u merged commit a9b1af4 into cncf:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@leecalcote leecalcote leecalcote approved these changes

@MUzairS15 MUzairS15 MUzairS15 approved these changes

Assignees
No one assigned
Labels
2024 lfx mentorship Term 2: June-Aug
Projects
TAG Contributor Strategy Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yashsharma1911 @nate-double-u @leecalcote @MUzairS15