Proposal of OpenKruise project for LFX 2024 Jun-Aug #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 力铭 <[email protected]>
aliok
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks for the proposal @chrisliu1995.
I've left 2 comments.
Also, can you ask for a 👍 or an approval from one of the maintainers of OpenKruise listed here? https://raw.githubusercontent.com/cncf/foundation/main/project-maintainers.csv
Signed-off-by: 力铭 <[email protected]>
|
|
/lgtm |
|
As the final step, can @ringtail approve the PR or give a 👍 please? |
Signed-off-by: Ali Ok <[email protected]>
|
/lgtm |
aliok
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.