Set up plot testing infrastructure and tests for plot_coverage #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons around to reflect they are either used by all plots or a specific plot.
|
@dajmcdon checks are passing properly now! |
dajmcdon
requested changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) set up
DEVELOP.mdand subdirectories for usingvdiffrto test plots.b) Add tests for
plot_coverage(notonetype, see issue #516)c) move
compute_coverageandcompute_calibrationto their plot files because that's the only place those functions are used (to emulate howplot_widthis set up).d) move
test_legal_facetingandInteraction(...)togrp_processing_for_facets.Rsince those are used by multiple plots. Also add a test fortest_legal_faceting.e) rename
test-evaluate.Rtotest-evaluate_predictions.Rbecause the main file was renamed as well.