Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Tau-embedded samples #18

Open
wants to merge 6 commits into
base: HTT_skim_v1
Choose a base branch
from

Conversation

DennRoy
Copy link
Contributor

@DennRoy DennRoy commented Jul 31, 2023

In order to run Tau-embedded samples, an additional customization is required. This customization is based on these instructions, but contain some modifications in order for this to work with a newer CMSSW version and NanoAOD v12.

The easiest way to process embedded samples is to run them separately from data or MC, by using a separate overseer config. The embedded samples can be run along with all other data or MC samples. All necessary modifications needed for the embedded samples are implemented in the yaml file for the embedded samples. The differences compared to the nominal config are the path to the additional customization, and points to a different DBS instance ("phys03" instead of "global").

This PR is not ready to be merged, as I would like embedding experts to sign off on the customizations added here.

@kandrosov
Copy link
Collaborator

@DennRoy, there is a possibility to redefine parameters in the samples' yaml files. I think having a separate overseer_cfg_embeddedSamples.yaml is overkill. If redefine doesn't work for some reason, please, let me know, and I'll try to fix it on the RinKit side.
Please add yaml files with embedded samples for Run 2 eras to this PR

@DennRoy
Copy link
Contributor Author

DennRoy commented Aug 16, 2023

Thanks! I was able to successfully redo the test by adding those parameters to the yaml files, also testing the new pfns prefix argument.

Copy link
Collaborator

@kandrosov kandrosov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DennRoy ! Modifications look fine. Please update the RunKit sub-module to the current RunKit/main.

NanoProd/crab/Run2_2016/Embedded.yaml Show resolved Hide resolved
@kandrosov
Copy link
Collaborator

@DennRoy do you plan any other updates? If not, I am ok with merging this PR

@DennRoy
Copy link
Contributor Author

DennRoy commented Aug 18, 2023

The people from KIT are still looking into my suggested customization. They say it looks alright, but didn't get to directly compare the outputs yet with what they have.

@DennRoy
Copy link
Contributor Author

DennRoy commented Sep 13, 2023

It all works fine so far, but there's still one more issue related to some trigger bit information (IDs which were 15 for Taus before are not always that value anymore in nAODv12). I've been told that this could be related to some special trigger, which is also not yet implemented. The people at KIT are still working on this.
In any case, if we don't have this special trigger yet, there won't be a point to processing all of the embedded samples yet, so I'd suggest to keep this PR open until then.

@DennRoy
Copy link
Contributor Author

DennRoy commented Jun 28, 2024

Some additional details: I'm actually unable to process embedded samples for 2017. There's an error about the unavailability of DeepTau v2.1 branches in the input (only v2 seems to be available in there). The other eras (2016, 2016_HIMP, 2018) work fine though.

But apparently there's no problem for the KIT people when producing v9 NanoAODs.

@kandrosov
Copy link
Collaborator

@DennRoy thanks for the update.

  • Since this modification is Run 2 specific, I propose that you change the target branch from main to HTT_skim_v1 so that embedded samples can be produced under the same conditions as the other Run 2 skims.
  • You can run missing DeepTau v2p1 on top of miniAOD. It can be done by adding it to idsToAdd for embedded samples. Similar to how v2p5 was added to Run 2 skims.

@DennRoy DennRoy changed the base branch from main to HTT_skim_v1 July 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants