Sources now have independent ProductRegistry

[Dr15Jones]

PR description:

Sources can now update their ProductRegistry without affecting the rest of the system. The system will pick up the changes when they are needed.

PR validation:

Framework code compiles and framework related unit tests pass.

resolves cms-sw/framework-team#1207

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43495

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Print ES module dependences from Tracer #46929

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43495/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43495/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43496

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Print ES module dependences from Tracer #46929

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/Sources (core)
• FWCore/TestProcessor (core)
• IOPool/Input (core)
• IOPool/Streamer (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43498

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Print ES module dependences from Tracer #46929

[cmsbuild]

Pull request #47213 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: HeaderConsistency UnitTests
Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d79828/44088/summary.html
COMMIT: a52b578
CMSSW: CMSSW_15_0_X_2025-01-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47213/44088/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Add HardwareResourcesDescription class #47175
• @hahnjo Work around ROOT bug in HitPattern IO read rule #47209
• @Dr15Jones Fix edmDumpClassVersion call for CondFormats/L1TObjects #47184
• @makortel Remove unnecessary dummy object definitions from CondFormats/L1TObjects/src/classes.h #47181
• @Dr15Jones Rename BranchDescription to ProductDescription #47190
• @Dr15Jones Remove use of OpenMP threading #47201
• @iarspider Add missing methods to Style class #47202
• @mmusich add fillDescriptions to several ESproducers used at HLT (2/N) #47191

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d79828/44088/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d79828/44088/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016770
• DQMHistoTests: Total failures: 79
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4016671
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

None of the test failures are from this PR.

• The header inconsistency is intended and comes from Rename BranchDescription to ProductDescription #47190
• The unit test failure is a problem in the test itself which was not caused by changes in this PR. The issue happens if one of the CMSSW package is dependent upon a change in another CMSSW package which is not checked out by the unit test. The fix would be to checkout all packages in the dependency chain as part of the unit test. That is beyond the scope of this PR.

[makortel]

ignore tests-rejected with manual-override

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1