Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Phase-2 L1 Trigger NanoAOD #47178

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

artlbv
Copy link
Contributor

@artlbv artlbv commented Jan 24, 2025

PR description:

This PR adds the Phase-2 L1 Trigger custom Nano version from a standalone repo https://github.com/cms-l1-dpg/Phase2-L1Nano/ to CMSSW. It allows storing the L1 and P2GT objects and also adds some gen collections used for Phase-2 Object and Menu studies.

This nano flavour is added to autoNANO as @Phase2L1DPG and also two upgrade workflows are implemented to test/run this nano after the full DigiTrigger chain after the complete L1:

  • .781 - produces NANO in addition to FEVTDEBUG
  • .782 - produces only NANO

Thus these wfs can be used for testing Phase-2 L1 PRs in future @aloeliger @slaurila @RobertJWard.

Some more documentation is in the DPGAnalysis/Phase2L1TNanoAOD/README.md.

PR validation:

Tested with the workflows 29634.781 and 29634.782 and manually with cmsDriver.py -s NANO:@Phase2L1DPG on 15X TTbar relvals.

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47178/43417

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DPGAnalysis/L1TNanoAOD (l1, xpog)
  • DPGAnalysis/Phase2L1TNanoAOD (****)
  • PhysicsTools/NanoAOD (xpog)

The following packages do not have a category, yet:

DPGAnalysis/Phase2L1TNanoAOD
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@AdrianoDee, @Moanwar, @aloeliger, @cmsbuild, @DickyChant, @epalencia, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@AnnikaStein, @Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@artlbv
Copy link
Contributor Author

artlbv commented Jan 24, 2025

I added the new package DPGAnalysis/Phase2L1TNanoAOD to l1,xpog in this PR: cms-sw/cms-bot#2420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants