-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LST followups: better work divisions, concrete kernel dimension, some cleanup and fixes #47084
base: master
Are you sure you want to change the base?
LST followups: better work divisions, concrete kernel dimension, some cleanup and fixes #47084
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47084/43263 |
A new Pull Request was created by @ariostas for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Tagging @fwyzard since most (if not all) of the comments addressed were his |
test parameters:
|
@cmsbuild please test |
-1 Failed Tests: UnitTests RelVals-GPU Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS RelVals-GPU
Comparison SummarySummary:
|
there are a bunch of errors like
the same workflow step3 in the baseline ran OK. So, the crash seems related to this PR. |
This PR addresses some of the LST followups that we have listed in #46746.
Here is the list of fixes/changes:
cms::alpakatools::makeworkdiv
(instead of our customcreateWorkDiv
) and we now usecms::alpakatools::uniform_elements
for kernel loops.kVerticalModuleSlope
(previously namedlst_INF
). We're doing this in two steps instead of one since the data files also need to be updated. We ensure a smooth transition by first supporting both options and later removing the legacy one.c.c. @slava77 @VourMa