Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] Allow storing 2025 geometry in GEMGeometryParsFromDD #47007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeckang
Copy link
Contributor

@yeckang yeckang commented Dec 18, 2024

PR description:

  • The GEMGeometryParsFromDDD checks the number of GE21 chambers to decide if it works for Run 3 condition. If the number of chambers is in the range of Run 3 condition, it allows to dump the demonstrator chamber which has layer number 2 without layer 1.
  • In the 2024, we had 3 installed GE21 chambers. So the range is set as less than 4.
  • In the 2025, we are planning to install 4 more chambers, so we need to increase the range.
  • The update only works when we create the GEMRecoGeometryRcd, we don't expect any changes in the test or central production.
  • related PR : Allow storing 2024 geometry in GEMGeometryParsFromDD #44429

PR validation:

  • The geometry tag is created with the CondTools/Geometry/test/gemgeometrywriter.py, and we tested the geometry from the tag.
  • Without this update, the created geometry tag does not include the GE21 demonstrator. However, after the update, we could dump the GE21 demonstrator in the GEMRecoGeometryRcd.

@watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yeckang for master.

It involves the following packages:

  • Geometry/GEMGeometryBuilder (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @giovanni-mocellin, @jshlee, @martinamalberti, @slomeo, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9ba9f/43544/summary.html
COMMIT: 493ac93
CMSSW: CMSSW_15_0_X_2024-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47007/43544/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 355 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 6092
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3503905
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Dec 22, 2024

+1

some differences in regression likely are due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants