Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Apply code checks/format #47002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

PGO changes ( e.g. using relative source path instead of full path ) broke scram build code-checks rule. So it has not been running properly on PR. code-format was working but only code-checks i.e. clang-tidy did not work as it required correct compiler_command.json with correct source file paths.

Build rules are fixed now, so this PR applies code-checks ( and format) for those files which were merged with proper code-checks

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47002/43088

ERROR: Build errors found during clang-tidy run.

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02868/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/bits/alloc_traits.h:518:4: error: no matching function for call to 'construct_at' [clang-diagnostic-error]
  518 |           std::construct_at(__p, std::forward<_Args>(__args)...);
      |           ^~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02868/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/bits/vector.tcc:117:21: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<SiStripOfflineDQM::MapOptions>>::construct<SiStripOfflineDQM::MapOptions, const std::basic_string<char> &, edm::ParameterSet, const bool &, edm::ESGetToken<SiStripQuality, SiStripQualityRcd> &>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@@ -78,7 +78,7 @@ SiStripOfflineDQM::SiStripOfflineDQM(edm::ParameterSet const& pSet)
auto token = useSSQ ? QualityToken{esConsumes<edm::Transition::EndRun>(
edm::ESInputTag{"", tkMapPSet.getUntrackedParameter<std::string>("ssqLabel", "")})}
: QualityToken{};
tkMapOptions_.emplace_back(map_type, std::move(tkMapPSet), useSSQ, std::move(token));
tkMapOptions_.emplace_back(map_type, std::move(tkMapPSet), useSSQ, token);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be related to llvm/llvm-project#86404 . This might be fixed in llvm 19 , so I can try to update llvm 19 for clang IBs. For now I can revert this change and suppress the clang-tidy warning by adding //NOLINT for this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants