-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM] Apply code checks/format #47002
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47002/43088 ERROR: Build errors found during clang-tidy run.
|
@@ -78,7 +78,7 @@ SiStripOfflineDQM::SiStripOfflineDQM(edm::ParameterSet const& pSet) | |||
auto token = useSSQ ? QualityToken{esConsumes<edm::Transition::EndRun>( | |||
edm::ESInputTag{"", tkMapPSet.getUntrackedParameter<std::string>("ssqLabel", "")})} | |||
: QualityToken{}; | |||
tkMapOptions_.emplace_back(map_type, std::move(tkMapPSet), useSSQ, std::move(token)); | |||
tkMapOptions_.emplace_back(map_type, std::move(tkMapPSet), useSSQ, token); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be related to llvm/llvm-project#86404 . This might be fixed in llvm 19 , so I can try to update llvm 19 for clang IBs. For now I can revert this change and suppress the clang-tidy warning by adding //NOLINT for this line
PGO changes ( e.g. using relative source path instead of full path ) broke
scram build code-checks
rule. So it has not been running properly on PR.code-format
was working but onlycode-checks
i.e.clang-tidy
did not work as it required correctcompiler_command.json
with correct source file paths.Build rules are fixed now, so this PR applies
code-checks
( and format) for those files which were merged with proper code-checks