Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENERATORS] Apply code checks/format #46992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

PGO changes ( e.g. using relative source path instead of full path ) broke scram build code-checks rule. So it has not been running properly on PR. code-format was working but only code-checks i.e. clang-tidy did not work as it required correct compiler_command.json with correct source file paths.

Build rules are fixed now, so this PR applies code-checks ( and format) for those files which were merged with proper code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • GeneratorInterface/CepGenInterface (generators)
  • GeneratorInterface/Herwig7Interface (generators)
  • GeneratorInterface/LHEInterface (generators)
  • GeneratorInterface/Pythia6Interface (generators)
  • GeneratorInterface/Pythia8Interface (generators)
  • GeneratorInterface/RivetInterface (generators)
  • IOMC/ParticleGuns (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @fabiocos, @forthommel, @grzanka, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38707b/43529/summary.html
COMMIT: 719b5e6
CMSSW: CMSSW_15_0_X_2024-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46992/43529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 422
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509575
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants