-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GENERATORS] Apply code checks/format #46992
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46992/43077 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
|
PGO changes ( e.g. using relative source path instead of full path ) broke
scram build code-checks
rule. So it has not been running properly on PR.code-format
was working but onlycode-checks
i.e.clang-tidy
did not work as it required correctcompiler_command.json
with correct source file paths.Build rules are fixed now, so this PR applies
code-checks
( and format) for those files which were merged with proper code-checks