Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MiniAOD] Remove slimmedGenJets minimum pt cut #46981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR removes the minimum pt cut for slimmedGenJets (AK4 gen-jets) in MiniAOD, effectively storing gen-jets with pt > 3 GeV.

This PR presents one way that we can overcome the partonFlavour inconsistency between jets built at RECO-level and jets reclustered from MiniAOD inputs. By storing all gen-jets that we produce, there is no need to recluster gen-jets with MiniAOD and the gen-jets retain their partonFlavour values, as calculated at RECO level. For reco-jets that are reclustered with MiniAOD inputs, their flavour labelling can be retrieved from matched gen-jets.

PR validation:

  • Passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.

  • The event size increases from 83.83 to 84.58 kb/event (+0.9%), using an MC TTto4Q RunIII2024Summer24 AOD file as the input test file.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

enable nano

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9966a1/43540/summary.html
COMMIT: 88e29b0
CMSSW: CMSSW_15_0_X_2024-12-17-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46981/43540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 203 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 1143
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3508854
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.076 3.076 0.000 ( +0.0% ) 6.44 6.34 +1.7% 2.518 2.539
2500.002 3.192 3.192 0.000 ( +0.0% ) 5.78 5.68 +1.7% 2.546 2.977
2500.003 3.133 3.133 0.000 ( +0.0% ) 6.03 5.90 +2.2% 2.570 2.971
2500.011 1.644 1.644 0.000 ( +0.0% ) 10.30 9.96 +3.4% 2.360 2.626
2500.012 2.184 2.184 0.000 ( +0.0% ) 6.01 5.92 +1.6% 2.399 2.805
2500.013 1.999 1.999 0.000 ( +0.0% ) 8.46 8.28 +2.2% 2.414 2.728
2500.021 0.022 0.022 0.000 ( +0.0% ) 2.11 2.09 +1.1% 2.609 2.595
2500.022 0.022 0.022 0.000 ( +0.0% ) 2.00 2.01 -0.4% 2.596 2.600
2500.023 0.022 0.022 -0.000 ( -0.2% ) 1.97 1.92 +2.4% 2.462 2.460
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.59 1.59 +0.3% 2.703 2.701
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.80 1.79 +0.9% 2.649 2.659
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.82 1.80 +0.9% 2.619 2.625
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.72 1.72 +0.3% 2.705 2.708
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.74 1.70 +2.0% 2.680 2.673
2500.101 2.809 2.809 0.000 ( +0.0% ) 16.71 15.85 +5.5% 2.639 2.634
2500.111 1.462 1.462 0.000 ( +0.0% ) 32.37 31.13 +4.0% 2.329 2.325
2500.112 1.882 1.882 0.000 ( +0.0% ) 26.45 25.18 +5.0% 2.389 2.398
2500.131 0.747 0.747 0.000 ( +0.0% ) 37.79 36.15 +4.6% 1.477 1.495
2500.201 2.637 2.637 0.000 ( +0.0% ) 13.88 13.08 +6.1% 2.200 2.204
2500.211 1.805 1.805 0.000 ( +0.0% ) 27.78 25.30 +9.8% 2.396 2.393
2500.212 2.202 2.202 0.000 ( +0.0% ) 23.13 21.72 +6.5% 2.480 2.480
2500.221 2.037 2.037 0.000 ( +0.0% ) 14.55 13.96 +4.2% 2.113 2.124
2500.222 3.440 3.440 0.000 ( +0.0% ) 13.34 12.85 +3.8% 2.204 2.206
2500.223 9.406 9.406 0.000 ( +0.0% ) 4.30 4.11 +4.8% 2.227 2.285
2500.224 6.265 6.265 0.000 ( +0.0% ) 1.42 1.38 +3.1% 2.234 2.268
2500.225 6.312 6.312 0.000 ( +0.0% ) 1.31 1.28 +2.6% 2.433 2.494
2500.226 3.134 3.134 0.000 ( +0.0% ) 13.76 12.80 +7.5% 2.202 2.205
2500.227 1.437 1.437 0.000 ( +0.0% ) 24.03 22.93 +4.8% 1.452 1.446
2500.231 1.455 1.455 0.000 ( +0.0% ) 23.36 22.15 +5.5% 2.204 2.282
2500.232 2.461 2.461 0.000 ( +0.0% ) 21.41 19.88 +7.7% 2.389 2.395
2500.233 4.953 4.953 0.000 ( +0.0% ) 6.30 5.82 +8.1% 2.469 2.472
2500.234 3.841 3.841 0.000 ( +0.0% ) 1.81 1.76 +2.6% 2.173 2.433
2500.235 3.872 3.872 0.000 ( +0.0% ) 1.69 1.66 +1.3% 2.369 2.616
2500.236 2.251 2.251 0.000 ( +0.0% ) 22.63 20.04 +12.9% 2.381 2.385
2500.237 1.016 1.016 0.000 ( +0.0% ) 35.88 35.34 +1.5% 1.430 1.455
2500.241 9.404 9.404 0.000 ( +0.0% ) 8.24 8.12 +1.5% 1.928 1.920
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.66 1.69 -1.7% 1.583 1.725
2500.243 2.712 2.712 0.000 ( +0.0% ) 16.55 16.26 +1.8% 1.058 1.058
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.15 1.16 -0.2% 1.692 1.697
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.54 1.54 -0.1% 1.670 1.689
2500.901 1.778 1.778 0.000 ( +0.0% ) 47.66 48.15 -1.0% 1.444 1.442
2500.902 1.628 1.628 0.000 ( +0.0% ) 49.51 49.70 -0.4% 1.333 1.333
2500.911 14.041 14.041 0.000 ( +0.0% ) 8.61 8.52 +1.0% 1.089 1.087
2500.912 0.240 0.199 0.041 ( +20.3% ) 2.72 3.46 -21.5% 0.848 0.847
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.72 2.72 -0.1% 0.849 0.851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants