Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALCA] Replace abs with std::abs to fix clang warnings #46969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ALCA] Replace abs with std::abs to fix clang warnings #46969

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

PR description:

Title says it all. Links to compilation logs: 1, 2

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 17, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024 •
edited
Loading

cms-bot internal usage

@iarspider iarspider changed the title [ALCA-DB] Replace abs with std::abs to fix clang warnings [ALCA] Replace abs with std::abs to fix clang warnings Dec 17, 2024
@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46969/43042

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • Calibration/HcalCalibAlgos (alca)

@atpathak, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @bsunanda, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43487/summary.html
COMMIT: acb663c
CMSSW: CMSSW_15_0_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46969/43487/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43487/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43487/git-merge-result

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

  • Easy...

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_CLANG_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43499/summary.html
COMMIT: acb663c
CMSSW: CMSSW_15_0_CLANG_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46969/43499/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43499/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43499/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 46 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 90456 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 383664
  • DQMHistoTests: Total nulls: 273
  • DQMHistoTests: Total successes: 3126060
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.806 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.649 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2022.002001 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.002001 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.189 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.344 KiB SiStrip/MechanicalView
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 18 / 44 workflows

@smuzaffar
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46969/43093

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@iarspider iarspider force-pushed the iarspider-patch-20241217-1 branch from acb663c to c2bd665 Compare December 18, 2024 08:13
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46969/43102

@cmsbuild
Copy link
Contributor

Pull request #46969 was updated. @atpathak, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_CLANG_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0703/43539/summary.html
COMMIT: c2bd665
CMSSW: CMSSW_15_0_CLANG_X_2024-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46969/43539/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 58 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 90460 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 383663
  • DQMHistoTests: Total nulls: 273
  • DQMHistoTests: Total successes: 3126061
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.806 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.649 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2022.002001 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.002001 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.189 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.344 KiB SiStrip/MechanicalView
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 18 / 44 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved orp-pending pending-signatures tests-approved trk
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@iarspider @cmsbuild @perrotta @smuzaffar