Make HGCAL Validation reproducible

[felicepantaleo]

This PR optimizes HGCalValidator and fixes #46416

It also produces simTracksters morphology plots that were previously filled only for reco objects.

[cmsbuild]

cms-bot internal usage

[felicepantaleo]

• type hgcal
• type bugfix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43034

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
• Validation/HGCalValidation (dqm)

@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @hatakeyamak, @lecriste, @lgray, @missirol, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @vandreev11, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

test parameters:

• workflow_opts= -w upgrade
• workflow = 29688.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef4b2a/43471/summary.html
COMMIT: 2a6032f
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46962/43471/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 76 lines to the logs
• Reco comparison results: 21 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3618291
• DQMHistoTests: Total failures: 2170
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3616101
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 207 log files, 176 edm output root files, 47 DQM output files
• TriggerResults: found differences in 1 / 45 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43038

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43094

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43094/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43094/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[antoniovagnerini]

hi @felicepantaleo , could you apply the patch with the code reformatting, so that we close the loop?

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43122

[cmsbuild]

Pull request #46962 was updated. @Moanwar, @antoniovagnerini, @civanch, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef4b2a/43581/summary.html
COMMIT: d971df6
CMSSW: CMSSW_15_0_X_2024-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46962/43581/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 197 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3926494
• DQMHistoTests: Total failures: 2131
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3924343
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 219 log files, 188 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+dqm

[civanch]

+1

regression is lost in tracker