Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to new RNTuple version #46615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • std container used by IsoDeposit can now be split by RNTuple
  • xml attribute name was changed to rntupleStreamerMode

PR validation:

Code compiles.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46615/42513

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/BTauReco (reconstruction)
  • DataFormats/CSCRecHit (reconstruction)
  • DataFormats/Candidate (reconstruction)
  • DataFormats/Common (core)
  • DataFormats/DTRecHit (reconstruction)
  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/GEMRecHit (upgrade, reconstruction)
  • DataFormats/Histograms (dqm, core)
  • DataFormats/JetReco (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/PatCandidates (xpog, reconstruction)
  • DataFormats/RPCRecHit (reconstruction)
  • DataFormats/RecoCandidate (reconstruction)
  • DataFormats/TestObjects (core)
  • DataFormats/TrackReco (reconstruction)
  • DataFormats/TrackingRecHit (reconstruction)
  • DataFormats/TrajectorySeed (reconstruction)
  • SimDataFormats/GeneratorProducts (generators)

@Dr15Jones, @Moanwar, @antoniovagnerini, @bbilin, @ftorrresd, @hqucms, @jfernan2, @lviliani, @makortel, @mandrenguyen, @menglu21, @mkirsano, @rseidita, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@AlexDeMoor, @CeliaFernandez, @Fedespring, @HuguesBrun, @Ming-Yan, @Prasant1993, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @ahinzmann, @andrea21z, @andrzejnovak, @apsallid, @battibass, @bsunanda, @castaned, @cericeci, @fabiocos, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @jdamgov, @jdolen, @jhgoh, @jshlee, @lgray, @makortel, @mariadalfonso, @martinamalberti, @missirol, @mmusich, @mtosi, @nhanvtran, @ptcox, @rappoccio, @rovere, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @trocino, @varuns23, @watson-ij, @wddgit, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

NOTE: This change affects nothing we presently do. It is only needed once we want to read/write the ROOT RNTuple format.

@Dr15Jones
Copy link
Contributor Author

As a test, I used a private branch I have with an RNTuple based Source and OutputModule with this change and was able to read/write AOD and miniAOD files.

@makortel
Copy link
Contributor

makortel commented Nov 6, 2024

type -changes-dataformats

The changes here do not impact present production system.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32d18c/42622/summary.html
COMMIT: 1e9e243
CMSSW: CMSSW_14_2_X_2024-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46615/42622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 7, 2024

+1

@antoniovagnerini
Copy link

+1

@Moanwar
Copy link
Contributor

Moanwar commented Nov 7, 2024

+Upgrade

@hqucms
Copy link
Contributor

hqucms commented Nov 7, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants