Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Update sourceFile of beamspotdip DQM client #46614

Open
wants to merge 1 commit into
base: CMSSW_14_1_X
Choose a base branch
from

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #46613

Original PR description:

This PR updates the beamspotdip client (which publishes the online BeamSpot values to DIP and OMS) to read the BeamSpot result not from BeamFitResults.txt, which is produced by the beamhlt client, but from BeamFitResultsForDIP.txt, which is produced by the onlinebeammonitor and is the result of the arbitration between the beamspot values produced by the beam and beamhlt clients.

This fix should ideally solve cases where the beamhlt client is not running/not producing a valid result, as it happened this morning during the first 2024 HI StableBeams (see the empy BeamSpot plots in https://cmsoms.cern.ch/cms/fills/report?cms_fill=10329).

PR validation:

Code compiles, to be tested in online DQM at P5.

Backport

backport of #46613

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

A new Pull Request was created by @francescobrivio for CMSSW_14_1_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

backport of #46613

@francescobrivio
Copy link
Contributor Author

@cms-sw/dqm-l2 could you please test this PR in the playback machine?

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c49a80/42620/summary.html
COMMIT: 5c106b0
CMSSW: CMSSW_14_1_X_2024-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46614/42620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565646
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

  • P5 tests successful

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants